Fix: ttl format insert by disabling the chunk insert for that format #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphax-bouazzouni
changed the title
syphax-bouazzouni
force-pushed
the
fix/ttl-chunk-insert
branch
from
0929621
to
c866719
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #156 +/- ##
===========================================
- Coverage 87.05% 86.98% -0.08%
===========================================
Files 36 36
Lines 2626 2627 +1
===========================================
- Hits 2286 2285 -1
- Misses 340 342 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alexskr
reviewed
May 12, 2024
lib/goo/sparql/client.rb
Outdated
| dir = nil | ||
| response = nil | ||
| if file_path.end_with?('ttl') | ||
| bnodes_filter = file_path | ||
| file = File.foreach(bnodes_filter) |
There was a problem hiding this comment.
File.read must be used instead of File.foreach here; file content is not getting loaded.
There was a problem hiding this comment.
someday we will need to add unit tests to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #155