Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the OBO Foundry synchronization script #79

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

jvendetti
Copy link
Member

Our OBO Foundry synchronization script has been erring out with a JSON::ParserError. This pull request eliminates the use of GitHub GraphQL queries to fetch files form GitHub in favor of using simple HTTP requests. It also adds the faraday and faraday-follow_redirects gems to the gemspec file.

Resolves #78

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 54.92%. Comparing base (252edb2) to head (290c86d).

Files Patch % Lines
lib/ncbo_cron/obofoundry_sync.rb 17.64% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #79      +/-   ##
===========================================
+ Coverage    54.51%   54.92%   +0.40%     
===========================================
  Files           16       16              
  Lines         1240     1229      -11     
===========================================
- Hits           676      675       -1     
+ Misses         564      554      -10     
Flag Coverage Δ
unittests 54.92% <17.64%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jvendetti jvendetti self-assigned this Apr 30, 2024
@jvendetti jvendetti merged commit 26638bf into develop Apr 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants