use max_depth calculated by owlapi_wrapper for UMLS ontologies #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get max depth from the metrics.csv file which is already generated by owlapi_wrapper when new submission of UMLS ontology is created. Ruby code/sparql for calculating max_depth fails for large UMLS ontologie with AllegroGraph backend Addresses #181
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #182 +/- ##
===========================================
- Coverage 80.76% 80.04% -0.72%
===========================================
Files 63 63
Lines 4917 4917
===========================================
- Hits 3971 3936 -35
- Misses 946 981 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
code coverage went down for lib/ontologies_linked_data/metrics/metrics.rb because ruby/sparql code is no longer used for calculating metrics. That code should be removed eventually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get max depth from the metrics.csv file which is already generated by owlapi_wrapper when new submission of UMLS ontology is created. Ruby code/sparql for calculating max_depth fails for large UMLS ontologie with AllegroGraph backend
Addresses #181