Skip to content

Commit

Permalink
fix: remove $-zf-size from non-responsive XY Grid classes generation
Browse files Browse the repository at this point in the history
`$-zf-size` is only set within breakpoints. Breakpoints are not expected to be used around the `xy-vertical-grid-classes()` mixin.

Note: a more appropriate fix would be to rely on the `xy-cell()` mixin instead of `xy-cell-static()` to fully support explicit/implicit/null breakpoint option. However this may introduce breaking changes, so this will be kept for v6.6.0.

[This fix is compatible with v6.5]
  • Loading branch information
ncoden committed Jun 28, 2018
1 parent 07696c3 commit a4cac3f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scss/xy-grid/_classes.scss
Original file line number Diff line number Diff line change
Expand Up @@ -273,11 +273,11 @@
}

> .auto {
@include xy-cell-static(auto, false, $breakpoint: $-zf-size, $vertical: true);
@include xy-cell-static(auto, false, $vertical: true);
}

> .shrink {
@include xy-cell-static(shrink, false, $breakpoint: $-zf-size, $vertical: true);
@include xy-cell-static(shrink, false, $vertical: true);
}


Expand Down

0 comments on commit a4cac3f

Please sign in to comment.