Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Treat PHPUnit warnings as failures #379

Merged
merged 1 commit into from
May 19, 2022
Merged

ci: Treat PHPUnit warnings as failures #379

merged 1 commit into from
May 19, 2022

Conversation

jrchamp
Copy link
Collaborator

@jrchamp jrchamp commented May 10, 2022

Mirror upstream changes in the recommended GitHub Action: moodlehq/moodle-plugin-ci#165

@jrchamp jrchamp added the bug Fixes problems or reduces technical debt label May 10, 2022
@jrchamp jrchamp requested a review from a team May 10, 2022 19:36
@jrchamp jrchamp self-assigned this May 10, 2022
smbader
smbader approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@smbader smbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches upstream :)

@jrchamp jrchamp merged commit fe892ad into ncstate-delta:main May 19, 2022
@jrchamp jrchamp deleted the ci/phpunit-fail-on-warning branch May 19, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smbader smbader smbader approved these changes

Assignees

@jrchamp jrchamp

Labels
bug Fixes problems or reduces technical debt
Projects
Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrchamp @smbader