This repository has been archived by the owner on May 12, 2023. It is now read-only.
Override create DNS record #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need a way to ensure this does not create DNS in our production account. Had to add some top level context entries so that we can more easily override these with `-c` on the cli when deploying within CodeBuild. Also renamed the stacks to match what we previously did for the IIIF service
jgondron
requested review from
ialford,
jonhartzler,
mlkirkpatrick and
rdoughty
mlkirkpatrick
approved these changes
Oct 30, 2019
rdoughty
approved these changes
Oct 30, 2019
ialford
approved these changes
Oct 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need a way to ensure this does not create DNS in our production account. Had to add some top level context entries so that we can more easily override these with
-con the cli when deploying within CodeBuild. Also renamed the stacks to match what we previously did for the IIIF service