This repository has been archived by the owner on May 12, 2023. It is now read-only.
Group Approval with Test deployment stages #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes all pipelines to ensure that any QA and Approval steps are grouped within the same stage as the Deploy to the test environment. This will prevent an integrity issue that can occur if multiple invocations of the pipeline happen before the Approver can visit the test site. - Changed IIIF service deployment pipeline to group Deploy/QA/Approval into one stage. - Changed static-host-pipeline to group the deploy/approval actions under a test stage A few additional cleanups/fixes: - Found a new reference to mellon in the README and changed to marble - Changed default production stack names to include a -prod suffix to better match how we are now deploying these stacks - Renamed several stages and actions to be more consistent across the different pipelines - Fixed an issue with redeploying the lamba in manifest-passthrough-pipeline
ialford
approved these changes
May 17, 2019
rdoughty
approved these changes
May 17, 2019
jgondron
pushed a commit
that referenced
this pull request
May 17, 2019
… viewer - The previous PR #73 changed the source step names, but the artifact names that are passed around in the pipeline no longer matched those steps. Changed the artifact names to more closely match the source steps
jgondron
pushed a commit
that referenced
this pull request
May 17, 2019
- Added parameter to the iiif-service-pipeline to retrieve the host names of the target stacks and added links to the repo and test/prod services in the approval message - Added links to the repo and to the test/prod stacks in the approval message for the manifest services. These don't really have endpoints to review, so this is the best we can provide for now. - Added links to the repo and to the test/prod stacks in the approval message for static host pipelines Additional changes: - Fixed a few naming problems in the readme associated with the image viewer - The previous PR #73 changed the source step names, but the artifact names that are passed around in the pipeline no longer matched those steps. Changed the artifact names to more closely match the source steps
jgondron
pushed a commit
that referenced
this pull request
May 20, 2019
- Added parameter to the iiif-service-pipeline to retrieve the host names of the target stacks and added links to the repo and test/prod services in the approval message - Added links to the repo and to the test/prod stacks in the approval message for the manifest services. These don't really have endpoints to review, so this is the best we can provide for now. - Added links to the repo and to the test/prod stacks in the approval message for static host pipelines Additional changes: - Fixed a few naming problems in the readme associated with the image viewer - The previous PR #73 changed the source step names, but the artifact names that are passed around in the pipeline no longer matched those steps. Changed the artifact names to more closely match the source steps
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes all pipelines to ensure that any QA and Approval steps are grouped within the same stage as the Deploy to the test environment. This will prevent an integrity issue that can occur if multiple invocations of the pipeline happen before the Approver can visit the test site.
A few additional cleanups/fixes: