Mel 462

[wsill]

Deployment for ECS docker image as part of pipeline

[rdoughty]

I tried testing and got an error. I deleted the dockerhub image(hesburgh/marble-image-processing), pulled this branch, deployed it, and ran a test through the manifest pipeline. I got the following error - "Reason":"CannotPullContainerError: Error response from daemon: manifest for hesburgh/marble-image-processing:latest not found","TaskArn":"arn:aws:ecs:us-east-1:333680067100:task/7534c42a-5897-46f8-83f3-748f5e08397b"}],

The deploy/cloudformation/manifest-pipeline.yml parameter ContainerImageUrl default pointing to the Docker Hub image. Do we have to specify an image url? Or is something else wrong?

[ialford]

I tried testing and got an error. I deleted the dockerhub image(hesburgh/marble-image-processing), pulled this branch, deployed it, and ran a test through the manifest pipeline. I got the following error - "Reason":"CannotPullContainerError: Error response from daemon: manifest for hesburgh/marble-image-processing:latest not found","TaskArn":"arn:aws:ecs:us-east-1:333680067100:task/7534c42a-5897-46f8-83f3-748f5e08397b"}],

The deploy/cloudformation/manifest-pipeline.yml parameter ContainerImageUrl default pointing to the Docker Hub image. Do we have to specify an image url? Or is something else wrong?

Is the stack you built still up somewhere? I'd like to see the CloudFormation that is being deployed by the pipeline.

[wsill]

The latest image for the container repo is "marbl-image-1cs1q74l7njir:latest". The one you are using is the old hard coded one. As Ian suggested, we would have to look at your CloudFormation to see what ContainerImageUrl value it is passing.

[rdoughty]

Do we want that has a default value then?

I have updated that parameter and am now facing - Error response from daemon: pull access denied for marbl-image-1cs1q74l7njir, repository does not exist or may require 'docker login'","TaskArn":"arn:aws:ecs:us-east-1:333680067100:task/ea852ef4-623a-46f8-ad6c-f6ecc39de4d7"}

I'll try and work through that as well

[jgondron]

The existing changes look good. One additional thing we need added is tagging the ECR with the most recent build that passed testing and was successfully deployed to production. For an example of this, see https://github.com/ndlib/marble-blueprints/blob/master/deploy/cloudformation/iiif-service-pipeline.yml#L494

[ialford]

Please see @jgondron 's review on tagging the built images in ECR - other than that it looks pretty good to me.

[wsill]

Changes to add tag to ECR for production have been added.

[wsill]

Okay, added GitHub posting as requested by Justin. Ran a full test of pipeline at https://us-east-1.console.aws.amazon.com/codesuite/codepipeline/pipelines/marble-manifest-deployment-ProjectPipeline-QPTKU43ETC8H/view