This repository has been archived by the owner on May 12, 2023. It is now read-only.
Fix Image Service access logs #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a hotfix to get the deployment to work. This adds a bucket policy to the shared log bucket to allow the ALB to write access logs. For now this will only work when the image service is deployed to us-east-1. This additionally extends the timeout between the ALB and Cantaloupe based on testing performed when rendering large images. This will likely need to be reassessed once we determine the sizes we will support.
jonhartzler
approved these changes
Aug 5, 2019
ialford
approved these changes
Aug 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hotfix to get the deployment to work. This adds a bucket policy to the shared log bucket to allow the ALB to write access logs. For now this will only work when the image service is deployed to us-east-1. This additionally extends the timeout between the ALB and Cantaloupe based on testing performed when rendering large images. This will likely need to be reassessed once we determine the sizes we will support.