Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contact Us Page (1 of 2) #760

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Contact Us Page (1 of 2) #760

merged 3 commits into from
Apr 15, 2024

Conversation

calebjacob
Copy link
Collaborator

@calebjacob calebjacob commented Apr 15, 2024 •
edited
Loading

Partially implements: near/near-discovery#1064

Implements new Contact Us page for the gateway. We should merge this before the 2nd PR.

Part 2: near/near-discovery#1115

@calebjacob calebjacob mentioned this pull request Apr 15, 2024
Merged
@calebjacob calebjacob added the feature To highlight a PR's description in the 'New Features' changelog section label Apr 15, 2024
shelegdmitriy
shelegdmitriy approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@shelegdmitriy shelegdmitriy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Just one question: are we good to use <a> tag instead of <Link> here?

@calebjacob
Copy link
Collaborator Author

@shelegdmitriy It's a good question. I'm using simple <a> tags here since all of the links are external with target="_blank".

@calebjacob calebjacob merged commit ccc8ca9 into develop Apr 15, 2024
1 check passed
@calebjacob calebjacob deleted the feat/contact-us-page branch April 15, 2024 20:18
@shelegdmitriy
Copy link
Contributor

@shelegdmitriy It's a good question. I'm using simple <a> tags here since all of the links are external with target="_blank".

Oh, makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shelegdmitriy shelegdmitriy shelegdmitriy approved these changes

Assignees
No one assigned
Labels
feature To highlight a PR's description in the 'New Features' changelog section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calebjacob @shelegdmitriy