near.panic() deleted #171
Merged
near.panic() deleted #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
austinabell
reviewed
Aug 10, 2022
Comment on lines
71
to
73
| export function panicUtf8(msg) { | ||
| env.panic_utf8(msg); | ||
| } |
There was a problem hiding this comment.
is it intentional to keep this? Or is this intended to be if someone did not want to include the debug info (line number, etc)?
There was a problem hiding this comment.
See our discussion here: #131 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we are enforcing the usage of
throw Error(msg)over thenear.panic(msg)as a more familiar syntax for JS developers.Also, it appeared that
throw Error(msg)also prints the line where this error happened, which is useful.