Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

es2020 target in tsc to allow bigint literal #176

Merged
merged 7 commits into from
Aug 16, 2022
Merged

es2020 target in tsc to allow bigint literal #176

merged 7 commits into from
Aug 16, 2022

Conversation

ailisp
Copy link
Member

@ailisp ailisp commented Aug 11, 2022 •
edited
Loading

Address #174

@ailisp ailisp marked this pull request as ready for review August 15, 2022 07:43
@volovyks volovyks linked an issue Aug 15, 2022 that may be closed by this pull request
Can't use bigint literals or do arithmetic with es5 target #174
Closed
volovyks
volovyks approved these changes Aug 15, 2022
View reviewed changes
Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JGTM! Let's add a simple test with the BigInt operation.

@ailisp ailisp merged commit 2e9e197 into develop Aug 16, 2022
@ailisp ailisp deleted the es2020-target branch August 16, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volovyks volovyks volovyks approved these changes

@austinabell austinabell Awaiting requested review from austinabell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't use bigint literals or do arithmetic with es5 target
2 participants
@ailisp @volovyks