LookupMap set twise test added #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailisp
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Looks like this is a solid test. @doriancrutcher could you share your contract that was error in #191 ?
ailisp
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Looks like this is a solid test. @doriancrutcher could you share your contract that was error in #191 ?
|
@doriancrutcher merging this now, feel free to reopen if there are still some issues with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not able to reproduce the error described in #191, looks like it works. @doriancrutcher we can still merge this PR, but please, tell me if you are facing this problem in some edge cases.