Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename plain object -> class instance operation to "reconstruct" #218

Merged
merged 3 commits into from
Sep 15, 2022

Conversation

ailisp
Copy link
Member

@ailisp ailisp commented Sep 14, 2022

I think this naming describes the signature better: from plain object to class instance. Typically deserialize mean from bytes to object. Also aligns to #203 .

Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.
Let's merge it tomorrow.

@ailisp ailisp merged commit 5bf76fb into develop Sep 15, 2022
@ailisp ailisp deleted the reconstruct branch September 15, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants