TSC error suppression for latest versions #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @vunderkind . Please do a |
Thanks for your response. Doing so now! |
|
Done — I added another |
|
@vunderkind linter and build tests are not happy with these changes.
and push? |
|
@volovyks — thanks for the nudge! Ach, turned out I was modifying the file in the |
ailisp
approved these changes
Oct 27, 2022
waynenilsen
pushed a commit
to waynenilsen/near-sdk-js
that referenced
this pull request
Nov 10, 2022
* TSC error suppression for latest versions * TSC error suppression & lint fix Co-authored-by: Bo Yao <bo@near.org> Co-authored-by: Serhii Volovyk <SergeyVolovyk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem summary
Newer versions of TypeScript seem to be throwing compile-time errors deep within the
lib.dom.tsfile, with the error looking something like this:"node_modules/typescript/lib/lib.dom.d.ts(14578,11): error TS2430: Interface 'WebGL2RenderingContext' incorrectly extends interface 'WebGL2RenderingContextBase'.\n"A quick and dirty fix is to skip library checks, according to this discussion. That's what is contained in this pull request.
Env parameters
My machine, which recorded this issue, is a Macbook Pro (2019), running Node
v16.9.0, npm8.19.2and TypeScriptv4.8.4. This happened with the latest near app build vianpx create-near-app@latest.