Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build method in promise api to allow execute promise without return it #397

Merged
merged 1 commit into from
May 23, 2024
Merged

Add build method in promise api to allow execute promise without return it #397

merged 1 commit into from
May 23, 2024

Conversation

ailisp
Copy link
Member

@ailisp ailisp commented May 23, 2024

Fix #387

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Related issues/PRs

@ailisp ailisp requested a review from volovyks as a code owner May 23, 2024 08:03
@ailisp ailisp merged commit 9075631 into develop May 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volovyks volovyks Awaiting requested review from volovyks volovyks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Promise API allow build a promise but not return
1 participant
@ailisp