fix: remove receiver approval #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanakannzashi
requested review from
ChaoticTempest,
itegulov and
miraclx
as code owners
frol
approved these changes
May 23, 2023
ChaoticTempest
approved these changes
May 25, 2023
There was a problem hiding this comment.
LGTM: the NFT tests don't seem to be a part of the GH actions pipeline but ran it locally and everything seems to be working fine. I'm surprised we haven't ran into this issue more but probably because nft_resolve_transfer always gets passed a approved_account_ids which overrides that token_id key anyways.
Thanks for noticing this edge case!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should remove any approvals receiver already set.