-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configure global allocator by default #429
Conversation
LGTM! In the future (next major version), I think we
|
I agree, given that breaking changes are coming in now, and without squashing it might be hard to cherry-pick the non-breaking changes, maybe this is a good time to make this change given that the next release would be a major one (afaik)? Edit: actually re-reading this, seems weird if we were to have these two features. Maybe a better feature/name pattern is having |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay!
Okay, I've decided to switch the feature to be
The negative is that if a developer has disabled default features on the SDK and uses the |
custom-allocator
featureThis is only a breaking change if the allocator is set up manually in the contract (not using
near_sdk::setup_alloc!()
) AND the custom-allocator feature is not set. This needs to only be attached to the 4.0 release discussed in #387This progresses the goal of zero boilerplate. I also verified that the allocator is set up correctly in all allocator setup and feature usage combinations.