Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: private annotation codegen to include near_sdk prefix #491

Merged
merged 6 commits into from
Jul 30, 2021

Conversation

austinabell
Copy link
Contributor

noticed doing ref-finance/ref-contracts#34 that this dep reference is incomplete and requires a user to import near_sdk::env when any function is private.

Copy link
Member

@ChaoticTempest ChaoticTempest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Macros are fun

@mikedotexe
Copy link
Contributor

Interesting, this doesn't change anything from the perspective of a contract developer, does it?

@austinabell
Copy link
Contributor Author

Interesting, this doesn't change anything from the perspective of a contract developer, does it?

Not at all, just means they won't be required to import env if they aren't already using env (see https://github.com/near/core-contracts/blob/54f8267436058567b66efdaba3e790394f7f1529/w-near/src/lib.rs#L19 for one example of this)

@austinabell austinabell merged commit 7c6641c into master Jul 30, 2021
@austinabell austinabell deleted the austin/fix/private_codegen branch July 30, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants