Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: move macro generated types to pseudo-private module #771

Merged
merged 8 commits into from
Apr 14, 2022

Conversation

austinabell
Copy link
Contributor

Noticed these as well, should have never been exported. Assuming they aren't used anywhere.

These changes are a bit opinionated so input would be appreciated.

  1. Metadata moved because the format isn't stable and will likely change
  2. BorshIntoStorageKey moved because it's just used by macros and can be very confusing with BorshStorageKey

Copy link
Member

@ChaoticTempest ChaoticTempest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me to have this change as long as its only being used in the macros

Copy link
Contributor

@itegulov itegulov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Metadata API is most likely going to change in the next release so hiding in this release is definitely a good idea

@austinabell austinabell merged commit c2492e7 into master Apr 14, 2022
@austinabell austinabell deleted the austin/private_export branch April 14, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants