Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cmp traits for json_types::integers (#822) #823

Merged
merged 4 commits into from
May 24, 2022

Conversation

curryrasul
Copy link
Contributor

No description provided.

@curryrasul
Copy link
Contributor Author

curryrasul commented May 21, 2022

Should I do something else on this PR ? I don't have experience contributing to a big open source, so I don't know how the process is going (even after reading CoC and contributing.md)

@willemneal
Copy link
Contributor

@curryrasul It looks like you are out of date with the base branch so a rebase or merge is needed.

Then you'll need to install Docker and run the build_all.sh script in the examples directory to rebuild all of the example binaries. I think this requirement is a bit much and bloats the git history with wasm blobs, but as you can see form this lenik it's needed to pass this CI check: https://buildkite.com/nearprotocol/near-sdk-rs/builds/4085#84cdfb22-4179-4247-93d8-42174f6dec5f/114-2779

Lastly someone with the power (not me) needs to approve your PR to be tested by Github Actions.

Thanks for the quick PR!

@austinabell
Copy link
Contributor

Should I do something else on this PR ? I don't have experience contributing to a big open source, so I don't know how the process is going (even after reading CoC and contributing.md)

Nope, sorry this PR just had to wait for a few others to come in first that were time sensitive. I'll pull it in soon, nothing to do on your end

@austinabell austinabell merged commit 2751292 into near:master May 24, 2022
@curryrasul curryrasul deleted the u128_fixes branch June 5, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants