Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty owner tokens start_index error #962

Merged
merged 4 commits into from
Nov 28, 2022

Conversation

YellingOilbird
Copy link
Contributor

When the user's token_set is empty this method panics now in case of use

{
        ...
        from_index: None,
        limit: None,
}

But i propose for an empty list returned in this situation

When the user's `token_set` is empty this method panics now in case of use
```rust
        ...
        from_index: None,
        limit: None,
```
But i propose for an empty list returned in this situation
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's valid for sure. I wonder why there is the require below is there at all. Going to pull this in since it's just for a view call and this is minimally changing from previous

@austinabell austinabell merged commit 78c1644 into near:master Nov 28, 2022
@austinabell
Copy link
Contributor

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants