Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make event emit public #975

Merged
merged 2 commits into from
Nov 25, 2022
Merged

fix: make event emit public #975

merged 2 commits into from
Nov 25, 2022

Conversation

danielwpz
Copy link
Contributor

No description provided.

Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, yes, this is very valid. Do you mind updating the test case in https://github.com/near/near-sdk-rs/blob/master/near-sdk/tests/event_tests.rs to make sure we don't remove this in the future?

sth like:

mod private {
    use super::*;
    
    #[near_bindgen(event_json(standard = "another_standard"))]
    pub enum AnotherEvent {
        #[event_version("1.0.0")]
        Test,
    }
}

...

private::AnotherEvent::Test.emit()

which fails on current master.

If not, nbd, I'll pull in later today or tomorrow and do myself

@danielwpz
Copy link
Contributor Author

@austinabell sure, will do!

@austinabell
Copy link
Contributor

thanks for the contribution!

@austinabell austinabell merged commit 2d512eb into near:master Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants