Add Rails 7.1 to the test matrix #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orien
commented
Mar 19, 2024
Comment on lines
108
to
113
| test "can't be used to inject SQL using .where" do | ||
| assert_raises MySQLBinUUID::InvalidUUID do | ||
| expected_error = ActiveRecord.version.to_s < "7.1" ? MySQLBinUUID::InvalidUUID : ActiveRecord::StatementInvalid | ||
| assert_raises(expected_error) do | ||
| MyUuidModel.where(the_uuid: "' OR ''='").first | ||
| end | ||
| end |
There was a problem hiding this comment.
In Rails 7.1, the MySQLBinUUID::InvalidUUID error raised by this library gets wrapped in an ActiveRecord::StatementInvalid.
orien
commented
Mar 19, 2024
| @@ -8,11 +8,11 @@ concurrency: | |||
|
|
|||
| jobs: | |||
| tests: | |||
| continue-on-error: true | |||
There was a problem hiding this comment.
Disable the continue-on-error setting. This caused the workflow to always pass, even if a job failed.
orien
commented
Mar 19, 2024
| strategy: | ||
| fail-fast: false |
There was a problem hiding this comment.
Disable fail-fast. This prevents GitHub Actions from canceling remaining jobs if any job in the matrix fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's ensure compatibility with the latest version of Rails.