This repository has been archived by the owner on Nov 8, 2023. It is now read-only.
Add config options #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve security by not starting the container as root. As long as injected files are placed in the appropriate paths they will still be owned by the rabbitmq user.
Allow the user to explicitly name the default `vhost` to something other than `/`. Add option to disable peer verification of tls certificates. Remove unnecessary ownership changes of injected files.
blankdots
approved these changes
Jul 2, 2019
yes, all PRs that results in a modified docker image should be deployed and functionally verified via e2e-test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
Enhance security by not running the container initally as root user.
With the changes to the other components to use URI format for the mq connection configuration
having
/forces us to use URL encoded characters which lead to funky characters in the URI (%)by not using
/as default vhost we can circumvent this issue.Optionally disable peer verification peer verification, for testing purposes.
Changes made:
Related issues:
Additional information:
Release note:
Documentation change:
Mentions: