Skip to content
This repository has been archived by the owner on Nov 8, 2023. It is now read-only.

NoTLS option #minor #21

Merged
merged 4 commits into from
Nov 30, 2021
Merged

NoTLS option #minor #21

merged 4 commits into from
Nov 30, 2021

Conversation

jbygdell
Copy link
Collaborator

Describe the pull request:

  • Bug fix
  • Functional change
  • New feature
  • Code cleanup
  • Build system change
  • Documentation change
  • Language translation

Pull request long description:

Changes made:

  1. Updated the docker image to use 3.8.16
  2. updated the config semantics to match 3.8.x
  3. Entrypoint script no longer creates self signed certificates
  4. Adds the NOTLS option to start with SSL disabled

Related issues:

Additional information:

Release note:

Documentation change:

Mentions:

entrypoint.sh Outdated Show resolved Hide resolved
entrypoint.sh Show resolved Hide resolved
Copy link

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@blankdots blankdots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

not sure we want to remove hooks folder with this or another PR

This is not needed anymore since Docker Hub is not building images any longer.
Copy link

@dbampalikis dbampalikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I didn't test it

Copy link

@norling norling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't figure out how test it, but as far as I can tell it looks good!

@norling norling merged commit f122a3d into master Nov 30, 2021
@norling norling deleted the no_tls branch November 30, 2021 13:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants