Add hangingSignBlock method to BlockStateProvider
#1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sciwhiz12
added
enhancement
sciwhiz12
approved these changes
Sep 9, 2024
|
🚀 This PR has been released as NeoForge version |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method BlockStateProvider.signBlock does not support usages for data generating HangingSignBlocks.
This PR just adds a pair of methods in the same fashion as BlockStateProvider.signBlock that allow you to create the files from either a ResourceLocation or a ModelFile
Recreated because my Github had a small minor meltdown when trying to make the Registry Access PR too
Original PR: #1511