refactor: split serializer contexts to avoid rooting RestTransport (a…

…nd its deps) and negatively impacting AOT size when it's not referenced

src/PineconeClient.cs

@@ -59,7 +59,7 @@ public PineconeClient(string apiKey, HttpClient client)
     public async Task<IndexDetails[]> ListIndexes(CancellationToken ct = default)
     {
         var listIndexesResult = await Http
-            .GetFromJsonAsync("/indexes", SerializerContext.Default.ListIndexesResult, ct)
+            .GetFromJsonAsync("/indexes", ClientContext.Default.ListIndexesResult, ct)
             .ConfigureAwait(false);
 
         return listIndexesResult?.Indexes ?? [];
@@ -118,7 +118,7 @@ public Task CreateServerlessIndex(string name, uint dimension, Metric metric, st
     private async Task CreateIndexAsync(CreateIndexRequest request, CancellationToken ct = default)
     {
         var response = await Http
-            .PostAsJsonAsync("/indexes", request, SerializerContext.Default.CreateIndexRequest, ct)
+            .PostAsJsonAsync("/indexes", request, ClientContext.Default.CreateIndexRequest, ct)
             .ConfigureAwait(false);
 
         await response.CheckStatusCode(ct).ConfigureAwait(false);
@@ -150,7 +150,7 @@ public async Task<Index<TTransport>> GetIndex<
         where TTransport : ITransport<TTransport>
     {
         var response = await Http
-            .GetFromJsonAsync($"/indexes/{UrlEncoder.Default.Encode(name)}", SerializerContext.Default.IndexDetails, ct)
+            .GetFromJsonAsync($"/indexes/{UrlEncoder.Default.Encode(name)}", ClientContext.Default.IndexDetails, ct)
             .ConfigureAwait(false) ?? throw new HttpRequestException("GetIndex request has failed.");
 
         // TODO: Host is optional according to the API spec: https://docs.pinecone.io/reference/api/control-plane/describe_index
@@ -196,7 +196,7 @@ public async Task ConfigureIndex(string name, int? replicas = null, string? podT
             .PatchAsJsonAsync(
                 $"/indexes/{UrlEncoder.Default.Encode(name)}",
                 request,
-                SerializerContext.Default.ConfigureIndexRequest,
+                ClientContext.Default.ConfigureIndexRequest,
                 ct)
             .ConfigureAwait(false);
 
@@ -221,7 +221,7 @@ public async Task DeleteIndex(string name, CancellationToken ct = default) =>
     public async Task<CollectionDetails[]> ListCollections(CancellationToken ct = default)
     {
         var listCollectionsResult = await Http
-            .GetFromJsonAsync("/collections", SerializerContext.Default.ListCollectionsResult, ct)
+            .GetFromJsonAsync("/collections", ClientContext.Default.ListCollectionsResult, ct)
             .ConfigureAwait(false);
 
         return listCollectionsResult?.Collections ?? [];
@@ -237,7 +237,7 @@ public async Task CreateCollection(string name, string source, CancellationToken
     {
         var request = new CreateCollectionRequest { Name = name, Source = source };
         var response = await Http
-            .PostAsJsonAsync("/collections", request, SerializerContext.Default.CreateCollectionRequest, ct)
+            .PostAsJsonAsync("/collections", request, ClientContext.Default.CreateCollectionRequest, ct)
             .ConfigureAwait(false);
 
         await response.CheckStatusCode(ct).ConfigureAwait(false);
@@ -254,7 +254,7 @@ public async Task<CollectionDetails> DescribeCollection(string name, Cancellatio
         return await Http
             .GetFromJsonAsync(
                 $"/collections/{UrlEncoder.Default.Encode(name)}",
-                SerializerContext.Default.CollectionDetails, 
+                ClientContext.Default.CollectionDetails, 
                 ct)
             .ConfigureAwait(false) ?? ThrowHelpers.JsonException<CollectionDetails>();
     }

src/Rest/SerializerContext.cs → src/Rest/Contexts.cs

@@ -1,34 +1,34 @@
 using System.Text.Json.Serialization;
-using Pinecone.Grpc;
 
 namespace Pinecone.Rest;
 
 [JsonSerializable(typeof(string[]))]
 [JsonSerializable(typeof(Metric))]
-[JsonSerializable(typeof(IndexStats))]
-[JsonSerializable(typeof(IndexState))]
-[JsonSerializable(typeof(IndexStatus))]
 [JsonSerializable(typeof(IndexDetails))]
-[JsonSerializable(typeof(Index<GrpcTransport>))]
-[JsonSerializable(typeof(Index<RestTransport>))]
+[JsonSerializable(typeof(MetadataValue[]))]
 [JsonSerializable(typeof(CreateIndexRequest))]
 [JsonSerializable(typeof(ConfigureIndexRequest))]
-[JsonSerializable(typeof(DescribeStatsRequest))]
 [JsonSerializable(typeof(CreateCollectionRequest))]
 [JsonSerializable(typeof(CollectionDetails))]
+[JsonSerializable(typeof(ListIndexesResult))]
+[JsonSerializable(typeof(ListCollectionsResult))]
+[JsonSourceGenerationOptions(
+    GenerationMode = JsonSourceGenerationMode.Default,
+    PropertyNamingPolicy = JsonKnownNamingPolicy.CamelCase,
+    DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull)]
+internal sealed partial class ClientContext : JsonSerializerContext;
+
+[JsonSerializable(typeof(DescribeStatsRequest))]
+[JsonSerializable(typeof(IndexStats))]
 [JsonSerializable(typeof(QueryRequest))]
 [JsonSerializable(typeof(QueryResponse))]
 [JsonSerializable(typeof(UpsertRequest))]
 [JsonSerializable(typeof(UpsertResponse))]
 [JsonSerializable(typeof(UpdateRequest))]
 [JsonSerializable(typeof(FetchResponse))]
 [JsonSerializable(typeof(DeleteRequest))]
-[JsonSerializable(typeof(MetadataMap))]
-[JsonSerializable(typeof(MetadataValue[]))]
-[JsonSerializable(typeof(ListIndexesResult))]
-[JsonSerializable(typeof(ListCollectionsResult))]
 [JsonSourceGenerationOptions(
     GenerationMode = JsonSourceGenerationMode.Default,
     PropertyNamingPolicy = JsonKnownNamingPolicy.CamelCase,
     DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull)]
-internal sealed partial class SerializerContext : JsonSerializerContext { }
+internal sealed partial class RestTransportContext : JsonSerializerContext;

src/Rest/Converters.cs

@@ -105,13 +105,13 @@ private static MetadataValue ReadValue(ref Utf8JsonReader reader)
 
     private static MetadataValue[] ReadArray(ref Utf8JsonReader reader)
     {
-        return JsonSerializer.Deserialize(ref reader, SerializerContext.Default.MetadataValueArray)
+        return JsonSerializer.Deserialize(ref reader, ClientContext.Default.MetadataValueArray)
             ?? ThrowHelpers.JsonException<MetadataValue[]>();
     }
 
     private static MetadataMap ReadMap(ref Utf8JsonReader reader)
     {
-        return JsonSerializer.Deserialize(ref reader, SerializerContext.Default.MetadataMap)
+        return JsonSerializer.Deserialize(ref reader, ClientContext.Default.MetadataMap)
             ?? ThrowHelpers.JsonException<MetadataMap>();
     }
 

src/Rest/RestTransport.cs

@@ -25,12 +25,12 @@ public async Task<IndexStats> DescribeStats(MetadataMap? filter = null, Cancella
     {
         var request = new DescribeStatsRequest { Filter = filter };
         var response = await Http
-            .PostAsJsonAsync("/describe_index_stats", request, SerializerContext.Default.DescribeStatsRequest, ct)
+            .PostAsJsonAsync("/describe_index_stats", request, RestTransportContext.Default.DescribeStatsRequest, ct)
             .ConfigureAwait(false);
 
         await response.CheckStatusCode(ct).ConfigureAwait(false);
         return await response.Content
-            .ReadFromJsonAsync(SerializerContext.Default.IndexStats, ct)
+            .ReadFromJsonAsync(RestTransportContext.Default.IndexStats, ct)
             .ConfigureAwait(false) ?? ThrowHelpers.JsonException<IndexStats>();
     }
 
@@ -64,12 +64,12 @@ public async Task<ScoredVector[]> Query(
         };
 
         var response = await Http
-            .PostAsJsonAsync("/query", request, SerializerContext.Default.QueryRequest, ct)
+            .PostAsJsonAsync("/query", request, RestTransportContext.Default.QueryRequest, ct)
             .ConfigureAwait(false);
 
         await response.CheckStatusCode(ct).ConfigureAwait(false);
         return (await response.Content
-            .ReadFromJsonAsync(SerializerContext.Default.QueryResponse, ct)
+            .ReadFromJsonAsync(RestTransportContext.Default.QueryResponse, ct)
             .ConfigureAwait(false))
             .Matches ?? ThrowHelpers.JsonException<ScoredVector[]>();
     }
@@ -83,12 +83,12 @@ public async Task<uint> Upsert(IEnumerable<Vector> vectors, string? indexNamespa
         };
 
         var response = await Http
-            .PostAsJsonAsync("/vectors/upsert", request, SerializerContext.Default.UpsertRequest, ct)
+            .PostAsJsonAsync("/vectors/upsert", request, RestTransportContext.Default.UpsertRequest, ct)
             .ConfigureAwait(false);
 
         await response.CheckStatusCode(ct).ConfigureAwait(false);
         return (await response.Content
-            .ReadFromJsonAsync(SerializerContext.Default.UpsertResponse, ct)
+            .ReadFromJsonAsync(RestTransportContext.Default.UpsertResponse, ct)
             .ConfigureAwait(false)).UpsertedCount;
     }
 
@@ -98,7 +98,7 @@ public async Task Update(Vector vector, string? indexNamespace = null, Cancellat
         Debug.Assert(request.Metadata is null);
 
         var response = await Http
-            .PostAsJsonAsync("/vectors/update", request, SerializerContext.Default.UpdateRequest, ct)
+            .PostAsJsonAsync("/vectors/update", request, RestTransportContext.Default.UpdateRequest, ct)
             .ConfigureAwait(false);
         await response.CheckStatusCode(ct).ConfigureAwait(false);
     }
@@ -127,7 +127,7 @@ public async Task Update(
         };
 
         var response = await Http
-            .PostAsJsonAsync("/vectors/update", request, SerializerContext.Default.UpdateRequest, ct)
+            .PostAsJsonAsync("/vectors/update", request, RestTransportContext.Default.UpdateRequest, ct)
             .ConfigureAwait(false);
         await response.CheckStatusCode(ct).ConfigureAwait(false);
     }
@@ -151,7 +151,7 @@ public async Task<Dictionary<string, Vector>> Fetch(
         }
 
         return (await Http
-            .GetFromJsonAsync(addressBuilder.ToString(), SerializerContext.Default.FetchResponse, ct)
+            .GetFromJsonAsync(addressBuilder.ToString(), RestTransportContext.Default.FetchResponse, ct)
             .ConfigureAwait(false)).Vectors;
     }
 
@@ -177,7 +177,7 @@ public Task DeleteAll(string? indexNamespace = null, CancellationToken ct = defa
     private async Task Delete(DeleteRequest request, CancellationToken ct)
     {
         var response = await Http
-            .PostAsJsonAsync("/vectors/delete", request, SerializerContext.Default.DeleteRequest, ct)
+            .PostAsJsonAsync("/vectors/delete", request, RestTransportContext.Default.DeleteRequest, ct)
             .ConfigureAwait(false);
         await response.CheckStatusCode(ct).ConfigureAwait(false);
     }