Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reinstate write-path key check #8973

Merged
merged 1 commit into from
Sep 10, 2024
Merged

reinstate write-path key check #8973

merged 1 commit into from
Sep 10, 2024

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Sep 9, 2024

Problem

In #8621, validation of keys during ingest was removed because the places where we actually store keys are now past the point where we have already converted them to CompactKey (i128) representation.

Summary of changes

Reinstate validation at an earlier stage in ingest. This doesn't cover literally every place we write a key, but it covers most cases where we're trusting postgres to give us a valid key (i.e. one that doesn't try and use a custom spacenode).

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

Copy link

github-actions bot commented Sep 9, 2024

3857 tests run: 3743 passed, 0 failed, 114 skipped (full report)


Flaky tests (1)

Postgres 15

Code coverage* (full report)

  • functions: 31.7% (7346 of 23155 functions)
  • lines: 49.9% (59499 of 119179 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
05c7804 at 2024-09-09T17:03:08.601Z :recycle:

@jcsp jcsp requested a review from skyzh September 9, 2024 21:11
@jcsp jcsp added the c/storage/pageserver Component: storage: pageserver label Sep 9, 2024
@jcsp jcsp marked this pull request as ready for review September 9, 2024 21:11
@jcsp jcsp requested a review from a team as a code owner September 9, 2024 21:11
@jcsp jcsp merged commit 26b5fcd into main Sep 10, 2024
78 checks passed
@jcsp jcsp deleted the jcsp/reinstate-key-check branch September 10, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/storage/pageserver Component: storage: pageserver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants