Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Improved security for import output to protect against XSS #93

Merged
merged 1 commit into from
Aug 3, 2023
Merged

[FIX] Improved security for import output to protect against XSS #93

merged 1 commit into from
Aug 3, 2023

Conversation

iseries
Copy link
Contributor

@iseries iseries commented Aug 2, 2023

In this commit, I've addressed a security concern related to the redirect import feature. Specifically, I've taken measures to eliminate a reflected cross-site scripting (XSS) vulnerability in the "import protocol" output.

In simple terms, I've added String.htmlSpecialChrars() to ensure that any user-generated data is now thoroughly encoded. This significantly minimizes the risk of malicious scripts being executed through the output.

If you have any questions about this commit or want more information about the changes, feel free to reach out to me. Your feedback and suggestions are always appreciated!

image

In this commit, I've addressed a security concern related to the redirect import feature. Specifically, I've taken measures to eliminate a reflected cross-site scripting (XSS) vulnerability in the "import protocol" output.
 
In simple terms, I've added String.htmlSpecialChrars() to ensure that any user-generated data is now thoroughly encoded. This significantly minimizes the risk of malicious scripts being executed through the output.

If you have any questions about this commit or want more information about the changes, feel free to reach out to me. Your feedback and suggestions are always appreciated!
Copy link
Member

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@Sebobo Sebobo merged commit 54aea2a into neos:master Aug 3, 2023
1 check passed
@iseries iseries deleted the iseries-patch-xss branch August 3, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants