add some more fields to repo, and structure for organization #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Some tests would be nice! |
|
Added tests! While resolving the conflict I realized I had duplicated the functionality in Stars.swift in new functionality in Repositories.swift, so I removed mine. |
|
Is there a reason NotificationTests.swift isn't part of the Xcode project and only runs in the SPM tests? |
No particular reason. I guess someone just forgot to add it as it's very easy to forget nowadays with Xcode opening the project as a package first. We can get rid of the Xcode Project at some point if we only want to support SPM and discard Carthage. Search Tests seem to fail for some reason once it's ready we can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @nerdishbynature, thanks for offering this package. I had a need for a few extra things from it, so wanted to offer this PR. Thanks!