Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use namespace import for mjml in adapter #984

Merged
merged 1 commit into from
Jun 21, 2023
Merged

fix: use namespace import for mjml in adapter #984

merged 1 commit into from
Jun 21, 2023

Conversation

jaqarrick
Copy link
Contributor

Closes #982

Description:
When using the MjmlAdapter from the mailer module the following error is thrown when the compile function is invoked:

TypeError: (0 , mjml_1.default) is not a function

Suggested Solution:
Use a namespace import for the mjml2html function.

juandav
juandav approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@juandav juandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juandav juandav merged commit 1f39b25 into nest-modules:master Jun 21, 2023
@jaqarrick jaqarrick deleted the fix-mjml-import-statement-982 branch June 21, 2023 17:54
@noamshvacher
Copy link

how can I install the version with this fix? @jaqarrick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juandav juandav juandav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import error using MjmlAdapter
3 participants
@jaqarrick @noamshvacher @juandav