Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(packages/microservices): pass inboxPrefix as argument to createInbox #13151

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

leandrogenas
Copy link
Contributor

@leandrogenas leandrogenas commented Feb 1, 2024

Pretty simple fix to correctly prepend the inboxPrefix to the NATS inbox ID

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

#13150

Issue Number: 13150

What is the new behavior?

The inbox prefix being added to the inbox ID

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build d9418cea-7a37-4776-9e7a-3ac67c5f7adf

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.197%

Totals Coverage Status
Change from base Build 889ffab4-7a4b-4e81-8f8a-630e303f4274: 0.0%
Covered Lines: 6723
Relevant Lines: 7292

💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit aee3701 into nestjs:master Feb 7, 2024
3 checks passed
@kamilmysliwiec
Copy link
Member

LGTM

@leandrogenas leandrogenas deleted the fix-inbox-prefix branch February 8, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants