Update proc plugin yaml #15460
Merged
Update proc plugin yaml #15460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/collectors
Ferroin
reviewed
Jul 20, 2023
| most_popular: false | ||
| overview: | ||
| data_collection: | ||
| metrics_description: '' | ||
| metrics_description: 'Examine Entropy metrics for insights into random number generation.' |
There was a problem hiding this comment.
I would suggest leaving this empty. There’s a single metric, and there will always be a single metric, so not much point in providing a description at the top.
Ferroin
reviewed
Jul 20, 2023
Ferroin
reviewed
Jul 20, 2023
Ferroin
reviewed
Jul 20, 2023
| most_popular: false | ||
| overview: | ||
| data_collection: | ||
| metrics_description: '' | ||
| metrics_description: "This integration provides the number of service requests that have been sent to the system's various interrupt lines." |
There was a problem hiding this comment.
Wrong section, load average has nothing to do with interrupts.
There was a problem hiding this comment.
that's true, must've slipped from my awareness, and inputted the wrong thing.
Ferroin
reviewed
Jul 20, 2023
Ferroin
reviewed
Jul 20, 2023
Ferroin
reviewed
Jul 20, 2023
Ferroin
reviewed
Jul 20, 2023
Ferroin
reviewed
Jul 20, 2023
Ferroin
reviewed
Jul 20, 2023
Ferroin
reviewed
Jul 20, 2023
Ferroin
reviewed
Jul 20, 2023
Ferroin
reviewed
Jul 20, 2023
Co-authored-by: Austin S. Hemmelgarn <austin@netdata.cloud>
Ferroin
reviewed
Jul 20, 2023
Ferroin
reviewed
Jul 20, 2023
Ferroin
reviewed
Jul 20, 2023
| icon_filename: '' | ||
| categories: | ||
| - data-collection.linux-systems.filesystem-metrics.nfs | ||
| icon_filename: 'syslog.png' |
There was a problem hiding this comment.
A network or filesystem related icon is probably better for this one.
Ferroin
reviewed
Jul 20, 2023
Ferroin
reviewed
Jul 20, 2023
| icon_filename: '' | ||
| categories: | ||
| - data-collection.linux-systems.filesystem-metrics.nfs | ||
| icon_filename: 'syslog.png' |
There was a problem hiding this comment.
Just like with the NFS client, this should probably be a filesystem or network related icon instead.
Ferroin
reviewed
Jul 20, 2023
Ferroin
reviewed
Jul 20, 2023
Ferroin
reviewed
Jul 20, 2023
Ferroin
reviewed
Jul 20, 2023
Ferroin
reviewed
Jul 20, 2023
Ferroin
reviewed
Jul 20, 2023
Co-authored-by: Austin S. Hemmelgarn <austin@netdata.cloud>
Ferroin
approved these changes
Jul 20, 2023
thiagoftsm
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Using this message from slack and googling where needed, updated the proc plugin. Also added our first nested categories inside linux-systems.
This was done manually, by hand, so maybe it is best to review quickly and actually see the result on testing to pick out any mistakes or hiccups.