Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix packaging mark stable static build #15854

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Aug 21, 2023

Summary

Fixes: #15853

Test Plan

Execute updated sed command, check git diff (RELEASE_CHANNEL should be updated in both netdata-installer.sh and install-or-update.sh files)

git diff
diff --git a/netdata-installer.sh b/netdata-installer.sh
index b6e65db35..093922ac6 100755
--- a/netdata-installer.sh
+++ b/netdata-installer.sh
@@ -280,7 +280,7 @@ NETDATA_PREFIX=
 LIBS_ARE_HERE=0
 NETDATA_ENABLE_ML=""
 NETDATA_CONFIGURE_OPTIONS="${NETDATA_CONFIGURE_OPTIONS-}"
-RELEASE_CHANNEL="nightly" # valid values are 'nightly' and 'stable'
+RELEASE_CHANNEL="stable" # valid values are 'nightly' and 'stable'
 IS_NETDATA_STATIC_BINARY="${IS_NETDATA_STATIC_BINARY:-"no"}"
 while [ -n "${1}" ]; do
   case "${1}" in
diff --git a/packaging/makeself/install-or-update.sh b/packaging/makeself/install-or-update.sh
index e4c133459..60c64a257 100755
--- a/packaging/makeself/install-or-update.sh
+++ b/packaging/makeself/install-or-update.sh
@@ -27,7 +27,7 @@ fi

 STARTIT=1
 REINSTALL_OPTIONS=""
-RELEASE_CHANNEL="nightly"
+RELEASE_CHANNEL="stable"

 while [ "${1}" ]; do
   case "${1}" in
Additional Information
For users: How does this change affect me?

@ilyam8 ilyam8 force-pushed the fix_packaging_mark_stable_static branch from b421624 to be0cf98 Compare August 21, 2023 11:24
@ilyam8 ilyam8 merged commit 2fe29f9 into netdata:master Aug 21, 2023
131 checks passed
@ilyam8 ilyam8 deleted the fix_packaging_mark_stable_static branch August 21, 2023 14:36
stelfrag pushed a commit to stelfrag/netdata that referenced this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: RELEASE_CHANNEL is set to nightly when installing stable static
3 participants