feat: support for basePath #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindsaylevine
added
the
type: feature
lindsaylevine
force-pushed
the
ll/feat/base-path
branch
from
c0b655f
to
d0fb79c
Compare
lindsaylevine
commented
Jun 1, 2021
| /getStaticProps/withFallback/:id /foo/getStaticProps/withFallback/:id 301! | ||
| /getServerSideProps/:id /foo/getServerSideProps/:id 301! | ||
| /getServerSideProps/all /foo/getServerSideProps/all/:[slug] 301! | ||
| /getServerSideProps/all/* /foo/getServerSideProps/all/:[slug] 301! |
|
you absolutely love to see failing tests on one os/node version 💯 |
|
Any idea what's going on here? It seems so strange |
|
@ascorbic it has to be the basePathSortFunc on that node version, that's the only thing that could affect the order like this. as for what's wrong with that sorting or includes check on that version, i have no idea 🙃 |
lindsaylevine
force-pushed
the
ll/feat/base-path
branch
from
c1e09f3
to
e1c090b
Compare
|
hm. yeah. its def this sorting issue, because this second try(/commit) failed in a different order than the first. will continue to see how i can eliminate it or make it independent of arg order (like that node issue suggests) |
lindsaylevine
force-pushed
the
ll/feat/base-path
branch
from
e1c090b
to
087fee1
Compare
lindsaylevine
force-pushed
the
ll/feat/base-path
branch
from
087fee1
to
906d9f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #131
note: my first stab at this work included touching every single pageType/redirects.js file (the way we did with i18n) to handle basePath there. with that flowing into several helpers and needing to import the config everywhere again, i opted for the performance cost of needing to loop over all the redirects after theyre collected (if there's a basePath configured) and building a new, basePath-supported collection of redirects. i have my old Logic Everywhere TM commit in a separate branch if anyone's curious lol
remaining issues: