Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat #178 #179

Merged
merged 3 commits into from
Apr 26, 2021
Merged

feat #178 #179

merged 3 commits into from
Apr 26, 2021

Conversation

BalloonWen
Copy link
Contributor

  • support relative base url

@BalloonWen
feat #178
9461c4b 
- support relative base url
@BalloonWen
issue #178
4cdf28f 
- will get base path from HandlerConfig and use that base path for normalizing paths
- deprecated the old normalized path constructor
@BalloonWen
issue-#178
8b0104c 
- enhanced tests
- fixed openapi was cached in different test classes
stevehu
stevehu approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@stevehu stevehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We should update the document to reflect the changes for the Kubernetes environment though.

@stevehu stevehu merged commit 0573dbb into master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehu stevehu stevehu approved these changes

@jaswalkiranavtar jaswalkiranavtar Awaiting requested review from jaswalkiranavtar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BalloonWen @stevehu