Tweak models that are now using different mosinit.hoc files #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now when a model contains multiple mosinit.hoc, the least-nested one is preferred. Before, the list of mosinit.hoc was sorted and the first one was used.
alexsavulescu
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#84 changed the conflict-resolution policy when finding
mosinit.hoc.Now, the least-nested one in the model directory structure is preferred.
Before, the list of paths was sorted and the first entry taken, so if there was a
mosinit.hocnested under a directory that sorts earlier (alphabetically) than "mosinit.hoc" then that one would be preferred.This fixes a few models where this change in behaviour caused errors.