Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of subworlds in CoreNEURON #2185

Merged
merged 28 commits into from
Jan 31, 2023
Merged

Initial implementation of subworlds in CoreNEURON #2185

merged 28 commits into from
Jan 31, 2023

Commits on Jan 24, 2023

  1. Initial implementation of subworlds in CoreNEURON, per Slack discussi… 

    …on 1/23/2023
    @iraikov
    iraikov committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    c9ad80c View commit details
    Browse the repository at this point in the history

  2. Removing modified hh.mod from pull request

    @iraikov
    iraikov committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    56afb9c View commit details
    Browse the repository at this point in the history

  3. Modifying tests for myid_bbs == -1 in various components of BBS in or… 

    …der to reflect the new semantics of myid_bbs and numprocs_bbs
    @iraikov
    iraikov committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    f5edb22 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of https://github.com/neuronsimulator/nrn into … 

    …iraikov/coreneuron_subworlds
    @iraikov
    iraikov committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    22b0c3f View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. formatting fixes; 

    added modified test_subworld
    @iraikov
    iraikov committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    821f7bf View commit details
    Browse the repository at this point in the history

  2. python formatting

    @iraikov
    iraikov committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    f59a13f View commit details
    Browse the repository at this point in the history

  3. adding nrnmpi_subworld_change_cnt to nrnmpi_def_cinc

    @iraikov
    iraikov committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    60dbb9e View commit details
    Browse the repository at this point in the history

  4. moving nrnmpi_change_subworld_cnt to nrnmpi_def_cinc

    @iraikov
    iraikov committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    ea35594 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into iraikov/coreneuron_subworlds

    @iraikov
    iraikov committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    5c02bd5 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'neuronsimulator:master' into iraikov/coreneuron_subworlds

    @iraikov
    iraikov authored Jan 25, 2023
    Configuration menu
    Copy the full SHA
    fdf2c4e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'iraikov/coreneuron_subworlds' of https://github.com/ira… 

    …ikov/nrn into iraikov/coreneuron_subworlds
    @iraikov
    iraikov committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    99a9341 View commit details
    Browse the repository at this point in the history

  8. removing unused nrnmpi_subworld; 

    adding comment about nrnmpi_subworld_change_cnt;
moving declaration of nrn2core_subworld_info_ to src/coreneuron/utils/utils.cpp;
set values of myid_bbs and numprocs_bbs on all ranks
    @iraikov
    iraikov committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    1aa54e7 View commit details
    Browse the repository at this point in the history

  9. formatting fixes; 

    adding corenrn subworlds test to ctest config;
somewhat more robust corenrn subworlds
    @iraikov
    iraikov committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    9936b6b View commit details
    Browse the repository at this point in the history

  10. enabling corenrn subworlds test only when MPI is enabled

    @iraikov
    iraikov committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    361d6c9 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. updated test_subworlds so that including stdrun.hoc is not necessary; 

    formatting fixes
    @iraikov
    iraikov committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    b9f2afc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into iraikov/coreneuron_subworlds

    @iraikov
    iraikov committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    5d09034 View commit details
    Browse the repository at this point in the history

  3. updated subworld doc

    @iraikov
    iraikov committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    11b9906 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. Revert "updated subworld doc" 

    This reverts commit 11b9906.
    @iraikov
    iraikov committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    b8355e1 View commit details
    Browse the repository at this point in the history

  2. reverting changes to numprocs_bbs and myid_bbs and using a separate v… 

    …ariable for subworld_id to pass to CoreNEURON via subworld_info
    @iraikov
    iraikov committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    1ce442a View commit details
    Browse the repository at this point in the history

  3. commenting out debug info

    @iraikov
    iraikov committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    ddc0955 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into iraikov/coreneuron_subworlds

    @iraikov
    iraikov committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    0acf61d View commit details
    Browse the repository at this point in the history

  5. added back pc.done to CoreNEURON subworlds test

    @iraikov
    iraikov committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    c03c5d2 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2023

  1. Merge branch 'master' into iraikov/coreneuron_subworlds

    @alexsavulescu
    alexsavulescu authored Jan 29, 2023
    Configuration menu
    Copy the full SHA
    b04a661 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. Merge branch 'master' into iraikov/coreneuron_subworlds

    @nrnhines
    nrnhines authored Jan 30, 2023
    Configuration menu
    Copy the full SHA
    2083007 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. added validation of number of world ranks, number of subworld ranks, … 

    …and ordering of ranks within subworld when CoreNEURON is invoked
    @iraikov
    iraikov committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    6000168 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into iraikov/coreneuron_subworlds

    @iraikov
    iraikov committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    e681bb5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'iraikov/coreneuron_subworlds' of https://github.com/ira… 

    …ikov/nrn into iraikov/coreneuron_subworlds
    @iraikov
    iraikov committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    5301035 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into iraikov/coreneuron_subworlds

    @nrnhines
    nrnhines authored Jan 31, 2023
    Configuration menu
    Copy the full SHA
    0ed08f8 View commit details
    Browse the repository at this point in the history