Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ltrim/rtrim to avoid using too much regex #2603

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

alkino
Copy link
Member

@alkino alkino commented Nov 8, 2023

No description provided.

@alkino alkino marked this pull request as ready for review November 8, 2023 07:57
Copy link
Member

@ohm314 ohm314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ohm314 ohm314 enabled auto-merge (squash) November 8, 2023 08:40
@bbpbuildbot

This comment has been minimized.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #2603 (eeca8e4) into master (fa132e4) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #2603      +/-   ##
==========================================
- Coverage   66.20%   66.19%   -0.01%     
==========================================
  Files         559      559              
  Lines      108910   108929      +19     
==========================================
+ Hits        72101    72108       +7     
- Misses      36809    36821      +12     
Files Coverage Δ
src/ivoc/strfun.cpp 95.08% <50.00%> (-4.03%) ⬇️

... and 4 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

✔️ eeca8e4 -> Azure artifacts URL

@ohm314 ohm314 merged commit c1ac797 into master Nov 8, 2023
36 checks passed
@ohm314 ohm314 deleted the cornu/rtrim_ltrim branch November 8, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants