Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error when dividing vector by zero #2605

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Raise error when dividing vector by zero #2605

merged 2 commits into from
Nov 9, 2023

Conversation

WeinaJi
Copy link
Collaborator

@WeinaJi WeinaJi commented Nov 8, 2023

No description provided.

src/ivoc/ivocvect.cpp Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #2605 (1f9e481) into master (c1ac797) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #2605      +/-   ##
==========================================
- Coverage   66.19%   66.19%   -0.01%     
==========================================
  Files         559      559              
  Lines      108930   108932       +2     
==========================================
- Hits        72109    72104       -5     
- Misses      36821    36828       +7     
Files Coverage Δ
src/ivoc/ivocvect.cpp 84.93% <66.66%> (-0.04%) ⬇️

... and 6 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@bbpbuildbot

This comment has been minimized.

Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

✔️ 1f9e481 -> Azure artifacts URL

@nrnhines nrnhines merged commit 9700e91 into master Nov 9, 2023
36 checks passed
@nrnhines nrnhines deleted the weji/vec_div branch November 9, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different behaviours from loading an ascii morphology file in hoc and in python
3 participants