Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HAVE_TMS code #2815

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Remove HAVE_TMS code #2815

merged 4 commits into from
Apr 9, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Apr 5, 2024 •
edited
Loading

HAVE_TMS was never defined, so I remove the code.

@azure-pipelines Azure Pipelines
Copy link

✔️ f87627a -> Azure artifacts URL

@alkino alkino marked this pull request as draft April 5, 2024 09:51
@alkino alkino changed the title Using nrn_timeus() everywhere Remove HAVE_TMS code Apr 5, 2024
@alkino alkino marked this pull request as ready for review April 5, 2024 10:15
@azure-pipelines Azure Pipelines
Copy link

✔️ 1858f6c -> Azure artifacts URL

@azure-pipelines Azure Pipelines
Copy link

✔️ 7f4c2cb -> Azure artifacts URL

@codecov Codecov
Copy link

codecov bot commented Apr 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.16%. Comparing base (6bb2781) to head (55eb8f8).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2815   +/-   ##
=======================================
  Coverage   67.15%   67.16%           
=======================================
  Files         562      562           
  Lines      104119   104114    -5     
=======================================
+ Hits        69922    69928    +6     
+ Misses      34197    34186   -11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Sign in to view
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #204205 (:white_check_mark:) have been uploaded here!

Status and direct links:

@azure-pipelines Azure Pipelines
Copy link

✔️ 55eb8f8 -> Azure artifacts URL

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

NEURON ModelDB CI: launching for 55eb8f8 via its drop url

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

NEURON ModelDB CI: 55eb8f8 -> download reports from here

@alkino alkino requested a review from JCGoran April 9, 2024 14:16
@alkino
Copy link
Member Author

alkino commented Apr 9, 2024

modeldb is ok ;)

JCGoran
JCGoran approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@JCGoran JCGoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good simplification!

@alkino alkino merged commit 6de86fc into master Apr 9, 2024
40 checks passed
@alkino alkino deleted the cornu/remove_have_tms branch April 9, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JCGoran JCGoran JCGoran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alkino @bbpbuildbot @JCGoran