-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for PR 3055 #3081
Test for PR 3055 #3081
Conversation
… for bitvector comparisons
✔️ 7ccc143 -> Azure artifacts URL |
On my machine (ubuntu 24.04 gcc 13.2.0) the test segfaults at the same point for gdb and address sanitizer. Ie frame 1 is at
Frame 0 is
At the moment I have no idea why
I see that the magic number 1000 in the context of ions appears in about 28 places. |
Co-authored-by: Luc Grosheintz <luc.grosheintz@gmail.com>
Co-authored-by: Luc Grosheintz <luc.grosheintz@gmail.com>
Co-authored-by: Luc Grosheintz <luc.grosheintz@gmail.com>
Co-authored-by: Luc Grosheintz <luc.grosheintz@gmail.com>
✔️ 3f5c418 -> Azure artifacts URL |
✔️ da974c2 -> Azure artifacts URL |
✔️ 3f213b0 -> Azure artifacts URL |
There does seem to be a bug in the newly merged to master #3055 which is revealed by the CI error for
Line 433 is
and the value of k can now be much larger than 32 (or 64). The point of this code is to raise a warning if two or more mechanisms at the same location write to the same ion concentration (e.g. cai or cao).
Also shouldn't
be before the Food for thought...
and the now forseeable memory use of a vector of thousands of bitsets that are thousands of bits long merely to check that there is no ion concentration write conflict after the model has been constructed (and it is to be expected there are only a few distinct mechanisms that write to the same ion concentration), it may be reasonable to use a different algorithm for checking for ion concentration write conflicts. |
✔️ 23071ee -> Azure artifacts URL |
✔️ 6604aab -> Azure artifacts URL |
✔️ ebf26b1 -> Azure artifacts URL |
The
but I don't know how to fix or avoid it. I wonder if it has to do with the addition of another mod file to neurondemo but I believe this error was occurring before the addition of that file. |
✔️ 06f9ace -> Azure artifacts URL |
Note about 06f9ace . On my machine Ubuntu 24.04 I have LCOV version 2.0-1 . With
I experience
Hence the change from |
✔️ 74d6029 -> Azure artifacts URL |
Quality Gate passedIssues Measures |
✔️ 1318a3f -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3081 +/- ##
==========================================
- Coverage 67.86% 66.89% -0.97%
==========================================
Files 572 572
Lines 104210 106671 +2461
==========================================
+ Hits 70718 71359 +641
- Misses 33492 35312 +1820 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the complications, this seems sensible.
This tests use of high mechanism index ions and mechanisms for #3055
At the moment there is a segfault for nion = 1000 but the test succeeds for nion = 950.
This PR should be based on wthun:master but I don' t know how to do that.