Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Commit

Permalink
Remove NamedModulesPlugin from @neutrinojs/hot (#818)
Browse files Browse the repository at this point in the history
Since webpack 4 now loads the plugin by default in development.

Leftover from #809.
  • Loading branch information
edmorley committed Apr 25, 2018
1 parent 0434e01 commit 541954c
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 9 deletions.
1 change: 0 additions & 1 deletion docs/packages/hot/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ The following is a list of plugins and their identifiers which can be overridden
| Name | Description | Environments and Commands |
| --- | --- | --- |
| `hot` | Enables Hot Module Replacement. | all |
| `named-modules` | Enables named modules for improved debugging and console output. | all |

## Contributing

Expand Down
1 change: 0 additions & 1 deletion docs/packages/node/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,6 @@ _Note: Some plugins are only available in certain environments. To override them
| `clean` | Clears the contents of `build` prior to creating a production bundle. | `build` command |
| `start-server` | Start a Node.js for the first configured main entry point. | `start` command |
| `hot` | Enables Hot Module Replacement. | `start` command |
| `named-modules` | Enables named modules for improved debugging and console output. From `@neutrinojs/hot`. | `start` command |

### Override configuration

Expand Down
1 change: 0 additions & 1 deletion packages/hot/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ The following is a list of plugins and their identifiers which can be overridden
| Name | Description | Environments and Commands |
| --- | --- | --- |
| `hot` | Enables Hot Module Replacement. | all |
| `named-modules` | Enables named modules for improved debugging and console output. | all |

## Contributing

Expand Down
7 changes: 2 additions & 5 deletions packages/hot/index.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
const { HotModuleReplacementPlugin, NamedModulesPlugin } = require('webpack');
const { HotModuleReplacementPlugin } = require('webpack');

module.exports = ({ config }) => config
.plugin('hot')
.use(HotModuleReplacementPlugin)
.end()
.plugin('named-modules')
.use(NamedModulesPlugin);
.use(HotModuleReplacementPlugin);
1 change: 0 additions & 1 deletion packages/node/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,6 @@ _Note: Some plugins are only available in certain environments. To override them
| `clean` | Clears the contents of `build` prior to creating a production bundle. | `build` command |
| `start-server` | Start a Node.js for the first configured main entry point. | `start` command |
| `hot` | Enables Hot Module Replacement. | `start` command |
| `named-modules` | Enables named modules for improved debugging and console output. From `@neutrinojs/hot`. | `start` command |

### Override configuration

Expand Down

0 comments on commit 541954c

Please sign in to comment.