Interrupt movement routine when desk stops moving #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abmantis
force-pushed
the
stop_move_on_button_press
branch
from
2f09fda
to
de6ac5e
Compare
abmantis
force-pushed
the
stop_move_on_button_press
branch
from
de6ac5e
to
c95b19d
Compare
newAM
requested changes
Oct 8, 2023
Co-authored-by: Alex Martens <alex@thinglab.org>
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the desk button is pressed while the desk is being moved from the library, the desk
stops. Without this change the lib will keep sending movement commands and the desk
would not be controllable anymore, until those commands are interrupted.
This change makes it so that the lib automatically detects that movement has seized
and so stops sending commands.