-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nrawssdk-v2: fix usage examples of nrawssdk.AppendMiddlewares #599
base: develop
Are you sure you want to change the base?
Conversation
@Meroje Hi, I'm taking a look at this and was wondering what this really changes other than when |
I found that the previous method had no effect and I would never get any telemetry from aws sdk. |
Oh ok, that's a good reason haha. Ok, I'll verify this and see if we can land it in an upcoming release. |
@Meroje are you able to sign the CLA here so that we can proceed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are approved and we're reviewing what potential changes to the integration may be needed to better support AWS as highlighted by this PR.
Links
Details
When testing the nrawssdk-v2 integration along with nrlambda I found out that the provided method of injecting the middleware to APIOptions does not work (no trace is seen for any aws call), what worked was to use the optFns param.
In this PR I'm only changing the documentation and example to reflect what has been working, but maybe you'd want to expand on it to add an exported function that can be used as an optFn ?
Also I could not find how to make the test fail as I'm not familiar enough with the internals.