Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removed scrollbar styling in generated API docs #2091

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

jsumners-nr
Copy link
Contributor

@jsumners-nr jsumners-nr commented Mar 20, 2024

@jsumners-nr jsumners-nr added the dev:deps Indicates updates to dev deps only label Mar 20, 2024
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.21%. Comparing base (666ae6e) to head (ce16288).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2091   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files         251      251           
  Lines       42398    42398           
=======================================
  Hits        41216    41216           
  Misses       1182     1182           
Flag Coverage Δ
integration-tests-16.x 78.24% <ø> (-0.02%) ⬇️
integration-tests-18.x 78.23% <ø> (+0.01%) ⬆️
integration-tests-20.x 78.24% <ø> (+<0.01%) ⬆️
unit-tests-16.x 90.59% <ø> (ø)
unit-tests-18.x 90.57% <ø> (ø)
unit-tests-20.x 90.57% <ø> (ø)
versioned-tests-16.x 74.50% <ø> (-0.03%) ⬇️
versioned-tests-18.x 75.62% <ø> (-0.03%) ⬇️
versioned-tests-20.x 75.62% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizob2828 bizob2828 self-assigned this Mar 21, 2024
Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have to npm i clean-jsdoc-theme@latest to get the update in package.json and the lock. Also I tried that and ran this and don't notice a difference

@jsumners-nr
Copy link
Contributor Author

I think you have to npm i clean-jsdoc-theme@latest to get the update in package.json and the lock. Also I tried that and ran this and don't notice a difference

🤦‍♂️ I don't know what I was thinking by not including the package update. And, yeah, the docs seem to be wrong for the feature. I toggled the setting to true and now things are styling sanely.

@bizob2828 bizob2828 merged commit cb0fa11 into newrelic:main Apr 1, 2024
22 checks passed
@jsumners-nr jsumners-nr deleted the docs-scrollbar branch April 1, 2024 16:22
@github-actions github-actions bot mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:deps Indicates updates to dev deps only
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants