ci: Updated the langchain vectorstore test to reference the correct version of @langchain/core getting tested
#2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion of `@langchain/core` getting tested
mrickard
approved these changes
May 20, 2024
jsumners-nr
approved these changes
May 20, 2024
There was a problem hiding this comment.
Approving, but I think we need to re-visit our version declaration and resolution rules. We have encountered this problem with at least one other monorepo backed set of modules (aws-sdk) where the modules expect to have sibling modules of the same or later versions from the same suite.
bizob2828
added a commit
that referenced
this pull request
May 20, 2024
…ersion of `@langchain/core` getting tested (#2202)
This was referenced Jul 20, 2024
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the case where
@langchain/coreis different than@langchain/community, the version of@langchain/coregetting instrumented varies. We have a test that asserts theSupportability/Nodejs/ML/Langchain/<versionmetric and it needed to be updated to get the right version. This adds a try catch and tries to assert the@langchain/coreversion from@langchain/communityfirst and if it does not exist falls back to the shared@langchain/coreversion.How to Test
npm run versioned:internal langchainRelated Issues
Closes #2201