Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Removed package-lock.json #2208

Merged
merged 2 commits into from
May 23, 2024
Merged

chore: Removed package-lock.json #2208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c13141d
chore: Removed package-lock.json
jsumners-nr May 22, 2024
6ba6fb7
add to gitignore
jsumners-nr May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm ci
run: npm install
- name: Run Linting
run: npm run lint
- name: Inspect Lockfile
Expand All @@ -84,7 +84,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm ci
run: npm install
- name: Run CI Script Unit Tests
run: npm run unit:scripts

Expand All @@ -108,7 +108,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm ci
run: npm install
- name: Run Unit Tests
run: npm run unit
- name: Archive Unit Test Coverage
Expand Down Expand Up @@ -140,7 +140,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm ci
run: npm install
- name: Run Docker Services
run: npm run services
- name: Run Integration Tests
Expand Down Expand Up @@ -178,7 +178,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm ci
run: npm install
- name: Run Docker Services
run: npm run services
- name: Run Versioned Tests
Expand Down Expand Up @@ -229,7 +229,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm ci
run: npm install
- name: Run Versioned Tests
run: TEST_CHILD_TIMEOUT=600000 npm run versioned:external
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/notify-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
with:
node-version: lts/*
- name: Install Dependencies
run: npm ci
run: npm install
- name: Check for PRs not yet released
run: node ./bin/pending-prs.js --repos $NR_REPOS --ignore-labels $IGNORE_LABELS
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/post-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm ci
run: npm install
- name: Setup GitHub Credentials
run: |
git config user.name $GITHUB_ACTOR
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/prep-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:
default: NEWS.md
changelog_json:
description: Whether or not it should generate a changelog.json (should only be for node-newrelic)
type: boolean
type: boolean
required: false

jobs:
Expand All @@ -41,7 +41,7 @@ jobs:
node-version: ${{ matrix.node-version }}
# Only need to install deps in agent-repo because of the bin scripts
- name: Install Dependencies
run: npm ci --prefix agent-repo
run: npm install --prefix agent-repo
- name: Setup GitHub Credentials
run: |
git config user.name $GITHUB_ACTOR
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
node-version: ${{ matrix.node-version }}
registry-url: 'https://registry.npmjs.org'
- name: Install Dependencies
run: npm ci
run: npm install
- run: npm publish
env:
NODE_AUTH_TOKEN: ${{ secrets.NODE_AGENT_NPM_TOKEN }}
4 changes: 2 additions & 2 deletions .github/workflows/release-creation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ jobs:
- name: Install Dependencies
run: |
# Install deps in caller repo
npm ci
npm install
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only concern I have in this PR is this line. I do not expect any problem as npm install should still install all dependencies. The difference would be if a repo that is reusing this workflow has updates to package.json and not package-lock.json. In that case, npm ci would notice the discrepancy and generate an error. Whereas npm install will install the dependencies as noted by package.json.

# Install deps in agent repo
npm ci --prefix agent-repo
npm install --prefix agent-repo
- name: Setup GitHub Credentials
run: |
git config user.name $GITHUB_ACTOR
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/smoke-test-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm ci
run: npm install
- name: Run Smoke Tests
run: npm run smoke
env:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/update-snyk-prs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@ jobs:
permissions:
pull-requests: write
runs-on: ubuntu-latest
if: ${{ github.event.sender.login == 'snyk-bot' }}
if: ${{ github.event.sender.login == 'snyk-bot' }}
steps:
- uses: actions/checkout@v3
- name: Use Node.js LTS
uses: actions/setup-node@v3
with:
node-version: lts/*
- name: Install Dependencies
run: npm ci
run: npm install
- name: Update Snyk PR Title
run: node ./bin/update-snyk-pr.js'
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/versioned-coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm ci
run: npm install
- name: Run Docker Services
run: npm run services
- name: Run Legacy Context Versioned Tests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/versioned-security-agent.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- name: Install Dependencies
run: npm ci
run: npm install
- name: Install Version ${{ inputs.version }} of security agent
if: ${{ inputs.version }}
run: npm install @newrelic/security-agent@${{ inputs.version }}
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
package-lock.json
node_modules
newrelic_agent.log
.coverage_data
Expand Down
1 change: 1 addition & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
package-lock=false
Loading
Loading