feat: Added instrumentation for kafkajs.Kafka.consumer
#2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
reviewed
Jun 4, 2024
|
|
||
| agent.on('transactionFinished', (tx) => { | ||
| const name = `MessageBroker/Kafka/Topic/Produce/Named/${topic}` | ||
| const segment = tx.agent.tracer.getSegment() | ||
| if (tx.name === expectedName) { |
There was a problem hiding this comment.
I don't understand the changes in this test. Why do we need to wrap the expectation in a conditional?
There was a problem hiding this comment.
consumers create transactions. We need to check which transaction is getting asserted so I named the producer transactions so we can do that
jsumners-nr
approved these changes
Jun 4, 2024
This was referenced Jul 20, 2024
This was referenced Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds instrumentation for
kafkajs.Kafka.consumer.run. I did not instrument eachBatch. I'm not sure how we should handle this. Our message shim handles transaction naming on a 1 message basis as it needs the topic name to name the consumption transaction. For now we will defer until someone asks for it. I plan on adding a story to track if customers are using this method. I had to tweak both the message-shim to allow to wrap a consumer when it is an object. The consumer arg of MessageSpec is a number so i addedfunctionsto allow to wrap n functions at the position of the consumer. Lastly, the traceparent and tracecontext are buffers so I had to handle parsing those as buffers.How to Test
Related Issues
Closes #2218